https://bugzilla.redhat.com/show_bug.cgi?id=976793 --- Comment #32 from Petr Menšík <pemensik@xxxxxxxxxx> --- It looks almost good. I found just /usr/share/Lunchbox/benchmarks/perf-* binaries from main package to be offending FHS. They are architecture dependent executables, I think they should be somewhere under /usr/libexec/Lunchbox/ or similar. Not sure they are useful in main package, I think they should have own subpackage or be part of -devel subpackage. I think /usr/share/Lunchbox/tests/ should be moved to devel subpackage too, it would not be useful to possible lunchbox dependent package builds. I think LICENSE.txt and LGPL.txt should be marked as %license, even when they have wrong address. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1 [obsolete FSF postal address (Temple Place)]", "GNU Lesser General Public License, Version 2.1", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 3", "GNU Lesser General Public License, Version 3 Boost Software License 1.0", "Boost Software License 1.0", "BSD 3-clause "New" or "Revised" License", "GNU Lesser General Public License v2.1 or later", "*No copyright* BSD 3-clause "New" or "Revised" License", "BSD 3-clause "New" or "Revised" License GNU General Public License, Version 2". 124 files have unknown license. Detailed output of licensecheck in /home/reviewer/fedora/rawhide/976793-lunchbox/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [!]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. -- original upstream license is provided too just as %doc [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: lunchbox-1.17.0-4.fc35.x86_64.rpm lunchbox-devel-1.17.0-4.fc35.x86_64.rpm lunchbox-debuginfo-1.17.0-4.fc35.x86_64.rpm lunchbox-debugsource-1.17.0-4.fc35.x86_64.rpm lunchbox-1.17.0-4.fc35.src.rpm lunchbox.x86_64: E: description-line-too-long C Lunchbox is C++ library for multi-threaded programming, providing OS abstraction, lunchbox.x86_64: E: arch-dependent-file-in-usr-share /usr/share/Lunchbox/benchmarks/perf-lfVector lunchbox.x86_64: E: arch-dependent-file-in-usr-share /usr/share/Lunchbox/benchmarks/perf-mutex lunchbox.x86_64: E: arch-dependent-file-in-usr-share /usr/share/Lunchbox/benchmarks/perf-rwLock lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/any.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/anySerialization.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/bitOperation.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/buffer.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/clock.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/debug.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/dso.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/file.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/future.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/init.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/intervalSet.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/issue1.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/lfQueue.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/memoryMap.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/monitor.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/mtQueue.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/perThread.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/perf/lfVector.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/perf/mutex.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/perf/rwLock.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/pluginFactory.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/refPtr.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/requestHandler.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/result.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/rng.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/string.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/thread.cpp lunchbox.x86_64: W: devel-file-in-non-devel-package /usr/share/Lunchbox/tests/threadPool.cpp lunchbox-devel.x86_64: W: no-documentation lunchbox.src: E: description-line-too-long C Lunchbox is C++ library for multi-threaded programming, providing OS abstraction, lunchbox.src:23: W: unversioned-explicit-provides bundled(eyescale-cmake-common) 5 packages and 0 specfiles checked; 5 errors, 30 warnings. Rpmlint (debuginfo) ------------------- Checking: lunchbox-debuginfo-1.17.0-4.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt : CHECKSUM(SHA256) this package : 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 CHECKSUM(SHA256) upstream package : 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 https://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt : CHECKSUM(SHA256) this package : dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 CHECKSUM(SHA256) upstream package : dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 https://github.com/Eyescale/CMake/archive/refs/tags/2018.02.tar.gz : CHECKSUM(SHA256) this package : 06ae367f70e34e5e5b27fac2296f7bdf33e36d5c016b1545020239fc49e5dd56 CHECKSUM(SHA256) upstream package : 06ae367f70e34e5e5b27fac2296f7bdf33e36d5c016b1545020239fc49e5dd56 https://github.com/Eyescale/Lunchbox/archive/1.17.0/lunchbox-1.17.0.tar.gz : CHECKSUM(SHA256) this package : 5d5e29ceacef6d024f3a1fa8178ae77a31fe41ebee82b36e76af5c65cd0f353b CHECKSUM(SHA256) upstream package : 5d5e29ceacef6d024f3a1fa8178ae77a31fe41ebee82b36e76af5c65cd0f353b Requires -------- lunchbox (rpmlib, GLIBC filtered): glibc libLunchbox.so.10()(64bit) libServus.so.6()(64bit) libboost_filesystem.so.1.75.0()(64bit) libboost_regex.so.1.75.0()(64bit) libboost_serialization.so.1.75.0()(64bit) libboost_system.so.1.75.0()(64bit) libboost_unit_test_framework.so.1.75.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) lunchbox-devel (rpmlib, GLIBC filtered): cmake libLunchbox.so.10()(64bit) lunchbox(x86-64) pkgconfig lunchbox-debuginfo (rpmlib, GLIBC filtered): lunchbox-debugsource (rpmlib, GLIBC filtered): Provides -------- lunchbox: bundled(eyescale-cmake-common) libLunchbox.so.10()(64bit) lunchbox lunchbox(x86-64) lunchbox-devel: lunchbox-devel lunchbox-devel(x86-64) lunchbox-debuginfo: debuginfo(build-id) libLunchbox.so.1.17.0-1.17.0-4.fc35.x86_64.debug()(64bit) lunchbox-debuginfo lunchbox-debuginfo(x86-64) lunchbox-debugsource: lunchbox-debugsource lunchbox-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 976793 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: fonts, Ocaml, SugarActivity, Java, Perl, Python, PHP, Haskell, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
