[Bug 1984419] Review Request: python-charset-normalizer - The Real First Universal Charset Detector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1984419

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mhroncok@xxxxxxxxxx



--- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Spec sanity:

> BuildRequires:  python3dist(pytest-cov)

Please don't use pytest-cov in %check if not hideously complicated to stop.

See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters

`rm setup.cfg` in %prep should do for now, a more complex sed is more future
proof.

We would need to remove it from RHEL 10 anyway, so better do it straight away.



> Motivated by chardet, I'm trying to resolve the issue by taking a new approach.

I would not use "I" in package descriptions, it sounds weird.





Looks good otherwise, straight and simple specfile, thanks.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux