https://bugzilla.redhat.com/show_bug.cgi?id=1982616 Christopher Engelhard <ce@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ce@xxxxxxx) | --- Comment #6 from Christopher Engelhard <ce@xxxxxxx> --- Thanks, Otto, Remi for the comments. > 1. > > License: BSD > That is what LICENSE and composer.json files say. > Source files claim to be under MIT > and then refer to nonexistent file LICENSE.txt. > Even though any possible interpretation is allowed in Fedora, > the license is unclear. > Upstream must be contacted about this unclarity > so that LICENSE file and source file headers can be made to agree. > However, since it is quite clear that BSD 2-Clause is the intended license, > I do consider it necessary to wait for a fix > before this package can be added to fedora. That makes sense. There is already an old issue regarding this upstream [1], which unfortunately hasn't been responded to. I'll see if I can get hold of the owner, they're still quite active on Github. > 2. > > : No tests implemented > Same comment as for php-leagure-uri-interfaces [1]: > There are tests upstream, but they remove them from Git archives. > I would like to seem them ran, but not sure how to make that happen. > [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1982635 Here I can use a local git checkout to create a source tarball that includes the tests (See for example here: [2]), as suggested by Remi. [1] https://github.com/beberlei/assert/issues/221 [2] https://src.fedoraproject.org/rpms/php-guzzlehttp-guzzle6/blob/rawhide/f/php-guzzlehttp-guzzle6.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
