[Bug 1984210] Review Request: build-constraints-rpm-macros - RPM macros for build constraints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1984210



--- Comment #3 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
so this is basically a bit simplified from the Suse definitions in
https://build.opensuse.org/package/view_file/openSUSE:Factory/memory-constraints/memory-constraints.macros?expand=1,
which was in turn based on the Ceph definition in
https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/ceph.spec

- removed the cruft for disabling parallelism; this makes sense for Ceph but
does not make sense in the Suse macro, since the setting to control it was
automatically computed instead of user-specified
  - any spec can disable parallelism as usual, by overriding `_smp_build_ncpus`
- like Ceph, but unlike the Suse definition, use physical memory and not
physical+swap. We don't want swap thrashing during a build
- override _smp_build_ncpus instead of _smp_mflags (which is just
-j%{_smp_build_ncpus} anyway)

Thanks Neal!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux