[Bug 1982618] Review Request: php-christophwurst-id3parser - A pure ID3 parser based upon getID3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1982618



--- Comment #2 from Tomas Korbar <tkorbar@xxxxxxxxxx> ---
Hi Christopher,
i have a few comments, regarding this package.

[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 10 files have unknown license. Detailed
     output of licensecheck in /home/tkorbar/packaging/fedora/reviews/php-
     christophwurst-id3parser/php-christophwurst-id3parser/licensecheck.txt

----- I do not think that license should be GPLv3+ but GPLv3 instead.

[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/php/ID3Parser(php-
     lukasreschke-id3parser), /usr/share/php/ID3Parser/getID3(php-
     lukasreschke-id3parser), /usr/share/php/ID3Parser/getID3/Tags(php-
     lukasreschke-id3parser)

----- unfortunatelly this conflict will need to be resolved.
      You can use the solution Remi suggested.

[ ]: Package does not generate any conflict.

----- Same as before, there is a conflict with lukasreschkes project


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux