[Bug 1981110] Review Request: rust-cpufeatures - No-std compatible alternative to the is_x86_feature_detected! macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1981110



--- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
(In reply to Fabio Valentini from comment #1)
> Taking this review.
> 
> Looks like you'll need to add something like "ExclusiveArch: x86_64 aarch64".
> The crate does not compile on other architectures, and should also not be
> used on other architectures.
> 
This gonna restrict significantly the reach of dependent packages :(

> Alternatively, you could do something like what was done in the
> rust-cpuid-bool package for the same situation:
> https://src.fedoraproject.org/rpms/rust-cpuid-bool/blob/rawhide/f/rust-cpuid-
> bool.spec
> 
> Additionally, It would be great to use the changelog timestamp format
> without time and timezone.
> rust2rpm >= 18 will do that by default again.

I've reverted itt in my script, but I plqn to move to rpmautospec for all new
and updated packages.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux