https://bugzilla.redhat.com/show_bug.cgi?id=1978427 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review process. - package builds and installs without errors on Rawhide and Fedora 34 - latest version is packaged - reason for disabled test suite is documented - license matches upstream specification and text is installed with %license - conforms to Rust packaging guidelines Please regenerate the .spec file with rust2rpm 18 before importing the package to get the new consistent automatically generated %license and %doc entries and the changelog timestamp without time+timezone. You also might check if there are *any* tests that can be run without the font test data, i.e. if it's possible to run either unit-tests or doctests or integration tests that do not rely on those test files (i.e. "%cargo_test -- --lib", "%cargo_test -- --doc", or "%cargo_test -- --tests"). Running *some* tests is usually better than running *no tests at all*, but that's up to you. Otherwise, package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
