https://bugzilla.redhat.com/show_bug.cgi?id=1982616 Otto Urpelainen <oturpe@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ce@xxxxxxx) --- Comment #1 from Otto Urpelainen <oturpe@xxxxxx> --- I have reviewed this package.Two findings: 1. > License: BSD That is what LICENSE and composer.json files say. Source files claim to be under MIT and then refer to nonexistent file LICENSE.txt. Even though any possible interpretation is allowed in Fedora, the license is unclear. Upstream must be contacted about this unclarity so that LICENSE file and source file headers can be made to agree. However, since it is quite clear that BSD 2-Clause is the intended license, I do consider it necessary to wait for a fix before this package can be added to fedora. 2. > : No tests implemented Same comment as for php-leagure-uri-interfaces [1]: There are tests upstream, but they remove them from Git archives. I would like to seem them ran, but not sure how to make that happen. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1982635 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
