[Bug 1982635] Review Request: php-league-uri-interfaces - Common interface for URI representation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1982635



--- Comment #2 from Otto Urpelainen <oturpe@xxxxxx> ---
And two that are more questions than review findings:

1.
A release is packaged, but it downloaded by commit id rather than tag or GitHub
release. Nothing wrong with that, I am just curious why it is done like that
here?

2.
> Autoloader: /usr/share/php/League/UriInterfaces/autoload.php
I am surprised that this information is important enough
to be added to description.
Why?
Also, there would be a slight readability gain
from formatting this differently,
so it would not look so much like a specfile tag.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux