https://bugzilla.redhat.com/show_bug.cgi?id=1880953 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- (In reply to Andreas Maier from comment #2) > I'm very sorry for not having followed up on this - I simply missed it and > Tony Asleson pointed me to it. > > On your review comments: > > * "Please bump to 1.0.3": I have bumped the version to 1.0.4, the currently > released version. > > * "Files are 404": I'm not sure I understand what to fix here. The files > will be pulled in during the package build process, as I understand it. Can > you elaborate? > > * "You don't need to specify the BuildRequires twice": I removed the first > section of them, following the example at > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_example_python_spec_file. However, being a beginner in package > maintenance, I don't fully understand the package structure yet w.r.t. > Python 2 and Python 3. I understand that the current Fedora release does not > contain any Python 2 packages anymore. So why is there still a %package > statement for a python3-* package name when there is already a Name > definition for the python-* package name? What is the strategy for new > Python packages in Fedora, should they be named python3-* or python-*? > Yes we don't have Python 2 anymore, but we kept the python-X as main package and python3 as a subpackage, probably because otherwise we'd have to rename all our Python packages, > In addition, I changed: > > * Source to Source0 > > * Used "python%{python3_pkgversion}-" instead of "python3-". I found that in > several upstream packages, e.g. > https://src.fedoraproject.org/rpms/python-isort/blob/rawhide/f/python-isort. > spec > > The resulting spec file has been updated on the master branch of the > upstream repo at: Great! The package is approved but you still need to find a sponsor, see https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
