https://bugzilla.redhat.com/show_bug.cgi?id=1982800 Major Hayden 🤠 <mhayden@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mhayden@xxxxxxxxx | |m) | --- Comment #2 from Major Hayden 🤠 <mhayden@xxxxxxxxxx> --- (In reply to Ben Beasley from comment #1) > - It seems like you don’t really need the google-api-client BR, just the > “google-api-core[grpc]” from the “testing” extra. Changing > > %pyproject_buildrequires -r > > to > > %pyproject_buildrequires -x testing > > allows you to drop the explicit google-api-client BR. That's awesome and I didn't realize that was possible! > - This > > %if %{with tests} > BuildRequires: python3-pytest > %endif > > would be better written as > > %if %{with tests} > BuildRequires: python3dist(pytest) > %endif > > and these > > BuildRequires: python3-sphinx > BuildRequires: python3-sphinx_rtd_theme > > would be better written as > > BuildRequires: python3dist(sphinx) > BuildRequires: python3dist(sphinx-rtd-theme) Thank you. Fixed. > - You can fix this: > > loading intersphinx inventory from > https://docs.python.org/3/objects.inv... > WARNING: failed to reach any of the inventories with the following > issues: > intersphinx inventory 'https://docs.python.org/3/objects.inv' not > fetchable > due to <class 'requests.exceptions.ConnectionError'>: > HTTPSConnectionPool(host='docs.python.org', port=443): Max retries > exceeded with url: /3/objects.inv (Caused by > NewConnectionError('<urllib3.connection.HTTPSConnection object at > 0xffff99f953c0>: Failed to establish a new connection: [Errno -3] > Temporary failure in name resolution')) > > In %prep, add: > > # Use local inventory in intersphinx mapping. > sed -r -i -e > 's|https://docs.python.org/3|/%{_docdir}/python3-docs/html|' \ > docs/conf.py > > and in %package doc, add > > Requires: python3-docs Done. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331888-python-proto-plus/python-proto-plus.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331888-python-proto-plus/python-proto-plus-1.19.0-1.fc35.src.rpm COPR fedora-review: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331888-python-proto-plus/fedora-review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
