https://bugzilla.redhat.com/show_bug.cgi?id=1956580 --- Comment #8 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- Sorry for the late answer... - The Obsoletes/Provides are still not correct. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages Should be: Obsoletes : openalchemist < 0.4-34 Provides: openalchemist = 0.4-34 - Add a comment on top of the openalchemist/alchemyquest symlink Something like: # Running alchemyquest through an openalchemist symlink will launch the game # in openalchemist mode w/o needing a command line option. - Source0: line could be shortened to: Source0: %{url}/%{name}-%{version}.tgz - Add a comment on top of License: to explain which part belongs to which license. - The build succeeded on F34, but failed on Rawhide, you should probably take a look. - fedora-review is also complaining about the size of the data and suggests a NoArch sub-package for that. I feel this is overkill for less than 10 MB, do as you see fit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
