https://bugzilla.redhat.com/show_bug.cgi?id=1979724 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Approved by inspection of the diff from the previous submission (but please do still change “%{python3_pkgversion}” to "3”—the macro is allowable but pointless in this case!). > --- ../1979724-python-applicationinsights/srpm-unpacked/python-applicationinsights.spec 2021-07-15 11:49:21.584855762 -0400 > +++ ./python-applicationinsights.spec 2021-07-15 20:06:57.785945336 -0400 > @@ -1,3 +1,6 @@ > +# tests are enabled by default > +%bcond_without tests > + > %global srcname applicationinsights > > Name: python-%{srcname} > @@ -15,6 +18,9 @@ > BuildRequires: python%{python3_pkgversion}-devel > BuildRequires: pyproject-rpm-macros > > +%if %{with tests} > +BuildRequires: python3-test > +%endif > > %global _description %{expand: > This project extends the Application Insights API surface to support Python} > @@ -48,6 +54,13 @@ > %pyproject_save_files applicationinsights > > > +%if %{with tests} > +%check > +PYTHONPATH=%{buildroot}/%{python3_sitelib} \ > + %{__python3} -m unittest discover ./tests/ > +%endif > + > + > %files -n python3-%{srcname} -f %{pyproject_files} > %license LICENSE.txt > %doc README.rst -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure