Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libopensync-plugin-gnokii - plugin for using gnokii with opensync https://bugzilla.redhat.com/show_bug.cgi?id=246351 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-11-21 16:21 EST ------- Full review done. Must Fix: -License field is wrong. Its GPL version 2 or any later verison, which the new license guideline requires you to state as GPLv2+ -Description must end with a "." -drop the ldconfig scripts, this is a plugin not a lib, so they are not needed. -Must have "Requires: libopensync" for %{_libdir}/opensync/plugins and %{_libdir}/opensync/formats dir ownership -doesn't compile on F-8: gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/opensync-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -Wall -Werror -O2 -I/usr/include/opensync-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MT gnokii_contact_format.lo -MD -MP -MF .deps/gnokii_contact_format.Tpo -c gnokii_contact_format.c -fPIC -DPIC -o .libs/gnokii_contact_format.o cc1: warnings being treated as errors gnokii_contact_format.c: In function 'conv_gnokii_contact_to_xml': gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Location' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Image' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_UserID' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_PTTAddress' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_FirstName' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_LastName' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_PostalAddress' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_ExtendedAddress' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Street' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_City' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_StateProvince' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_ZipCode' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Country' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_FormalName' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_JobTitle' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Company' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Nickname' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Birthday' not handled in switch make[2]: *** [gnokii_contact_format.lo] Error 1 make[2]: Leaving directory `/usr/src/redhat/BUILD/libopensync-plugin-gnokii-0.22 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review