https://bugzilla.redhat.com/show_bug.cgi?id=1965823 --- Comment #7 from Jan Staněk <jstanek@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #6) > I have created a similar script that uses cargo to repackage the crate > properly, which should also make sure no "vital" files are removed > accidentally. Fair enough, although I have one problem with it's current behaviour – after the script is run, it produces the file of the same name as the original crate. Two problems with that: 1. If you forget to run the gen_clean_tarball.sh, no-one will notice unless you explicitly check the content; then we are back to accidentally shipping the (arguably) non-free stuff. 2. When you do run the script, the hash of the original and the modified file will differ, and fedora-review (and I suspect that other diligent enough linters) will complain about it. Nothing that couldn't be waived, but still. I would strongly prefer if you could rename the re-packaged crate in the cleaning script (`opml-%{version}-stripped.crate` or something like that), and use `Source: %{name}-%{version}-stripped.crate` in the specfile (no `%{crates_source}`). That way you have to go through the script to get a new release tarball, and you are explicit in stating that we do not ship the crate directly from the upstream, but deliberately making changes to it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
