https://bugzilla.redhat.com/show_bug.cgi?id=1981978 --- Comment #3 from Scott Talbert <swt@xxxxxxxxxx> --- (In reply to Jerry James from comment #2) > Issues: > ======= > - Since this package is intended to replace the sip5 package, shouldn't it > have > Obsoletes and Provides for sip5? > > - Please add a comment explaining the patch (a SHOULD item) > > - If no other form of testing makes sense (such as building the examples), > then > this is now possible in Rawhide: > > %check > %py3_check_import sipbuild sipbuild.distinfo sipbuild.module sipbuild.tools Thanks for the review and comments. I have addressed all of these. I had thought about the Obsoletes and Provides for sip5 before but omitted them because all the users of sip5 (I believe) declare their dependencies using the python3dist(sip) name. But it can't hurt to add them anyway just so it's clear to everyone. Ideally this package should be just an update under the 'sip' name (and perhaps rename the existing package to sip4) but it seems like this was the easier route given that a lot of the legacy stuff uses the sip name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
