[Bug 1976529] Review Request: rust-cfg-expr - parser and evaluator for Rust `cfg()` expressions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1976529



--- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> It seems that fedora tools don't see optional dependency. It has been a few package that act like that maybe something is wrong with the tools.

fedora-review *should* complain if any of the built packages have unsatisfiable
dependencies. If it doesn't, then that's a bug in fedora-review, and please
report it here: https://pagure.io/FedoraReview

> But that doesn't matter since it's optional right?

It clearly *does* matter, or you wouldn't get a bug report for it. All package
dependencies MUST be satisfiable from Fedora repositories, even "weak"
dependencies (Recommends + Suggests) - though I don't remember which policy
covers this.

In this case, the broken dependency is only not a problem so long as no
dependent package uses the "target" feature of this package.

Possible solutions would be to either drop the "target" feature temporarily (if
really nothing uses it), or to bump the dependency from 0.11.2 to 0.12.0, which
is what's available in Fedora (assuming the package is compatible with the
newer version, test this with a build with "--all-features", or run all cargo
macros with the "-a" flag to test this).

PS: I try to run "mock ./*.src.rpm --postinstall" to check for unsatisfiable
dependencies of any built packages. It's very convenient.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux