Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: teg - teg is a clone of a clone of Risk https://bugzilla.redhat.com/show_bug.cgi?id=291371 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-11-21 14:02 EST ------- Okay, I've done a full review, looks good, many thanks to Mamoru for getting it into ints current shape. There are only 2 things which I would prefer to be changed (but this is not a blocker): 1) please move /usr/share/pixmaps/teg_icono.png to /usr/share/icons/hicolor/48x48/apps/teg.png And then change the Icon line in the .desktop to just "Icon=teg" And add the necessary scripts to update the icon cache (see the scripletsnippets page in the wiki) 2) You really should change the encoding of the docs in %prep, not at the end of %install I'll take a look at libopensync-plugin-foo and -bar next, once those 2 are approved too I'll sponsor you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review