Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: snake - a client/server python framework used to support anaconda installations https://bugzilla.redhat.com/show_bug.cgi?id=391091 ------- Additional Comments From jwilson@xxxxxxxxxx 2007-11-21 13:54 EST ------- Okay, first pass through the spec file: 1) numerous extraneous trailing spaces that should be deleted (shows up bright red w/my vim setup). 2) The awk thingies for Version and Release... Ew. Not particularly happy for a fedora package, though I dunno if it strictly violates guidelines or not. 3) spacing from one %section to another is a bit inconsistent (not a mustfix, but something that always bugs me). 4) the %description for server should be wrapped at 80 characters (rpmlint will complain about this) 5) use of /var instead of %{_localstatedir} 6) use of /etc instead of %{_sysconfdir} 7) changelog versioning doesn't match rpm versionsing (i.e., 0.9-1 is not the same as 0.9-0.3git) Now for a glance at rpmlint output... 1) non-executable-script errors on a bunch of .py files (all 0644) 2) the changelog thing mentioned above 3) the %description server line length thing 4) warning about the snake-server initscript enabling it by default. The guidelines generally don't permit services to be enabled by default, it should be left to the user to enable the service. 5) the 0660 perms on the files that comprise the srpm should generally be 0644. Either remedy the above issues or provide justification why you don't need to, and we'll rinse and repeat 'til we're both happy. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review