Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: diveintopython - The html book https://bugzilla.redhat.com/show_bug.cgi?id=389971 loganjerry@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |loganjerry@xxxxxxxxx ------- Additional Comments From loganjerry@xxxxxxxxx 2007-11-21 13:17 EST ------- The name of the spec file should be diveintopython.spec. If you are thinking that you will someday offer up other formats besides HTML, then you might want to consider starting with the DocBook sources and making subpackages for each target format (PDF, etc.) instead. Most of your rpmlint errors occur because of Windows-style line endings in the HTML files and some (but not all) of the Python files. If you generate the HTML files from the DocBook sources, that won't happen for them (but will still be a problem for the Python files). Otherwise, you need to do something like this: # Change Windows line endings to Unix line endings for file in $(find . -type f); do sed -i 's/\r//' $file done There are also one XML file that is KOI8-R encoded. Even though rpmlint complains about it, you shouldn't touch it. It is KOI8-R on purpose. The license tag should be GFDL. You don't need to list basesystem in your BuildRequires or Requires. You also should not list python in Requires, since it is not necessary to use this package. True, you need python to run any of the examples, but you can look at the web pages without it, so it is required in sense that people need it to get full utility out of your package, but it is not Required in the RPM sense that the package doesn't work without it. On the other hand, your package does Require (in the RPM sense) xdg-utils. Your %postun script is wrong. If you have to remove something afterwards, that means your package didn't "own" enough. To fix this problem, remove the %postun script entirely, and change your %install and %files sections to these: %install rm -rf $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT%{_datadir}/applications desktop-file-install --vendor="fedora" \ --dir=${RPM_BUILD_ROOT}%{_datadir}/applications \ --add-category="Documentation" \ %{SOURCE1} %files %defattr(-,root,root,-) %doc . %{_datadir}/applications/fedora-diveintopython.desktop -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review