https://bugzilla.redhat.com/show_bug.cgi?id=1980282 Graham White <graham_alton@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@xxxxxxxxx | |) --- Comment #6 from Graham White <graham_alton@xxxxxxxxxxx> --- Thanks for taking the time to do the review and all your extra detail, that was all extremely helpful. I have updated the spec file and built a new set of RPMS, all uploaded to https://grahamwhiteuk.fedorapeople.org/pkgreviews/exaile/ I have also submitted 3 patches upstream: 1) https://github.com/exaile/exaile/pull/759 - Preserve timestamp upon file installation. 2) https://github.com/exaile/exaile/pull/760 - Use the correct address for the FSF 3) https://github.com/exaile/exaile/pull/761 - Remove shebangs from plugins installed without execute perms Changes made are: * Set Fedora default build flags - added %set_build_flags to the %build section * Keep timestamps and defer byte compilation to brp-python-bytecompile - spec file modifies the Makefile to add -p flag to install command (this aspect will be remove if PR 759 is accepted upstream) - spec file modifies the Makefile to remove the compilation step * Re-enabled tests, I've no idea why this was disabled by the previous packagers - patch d8bbcfd174b658babb6605799d1e9e788b578c84 incorporated to facilitate successful tests until next upstream release (where the patch has been merged upstream) * Updated BuildRequires - as indicated in the above package review and to include additional BRs to allow the tests to execute * Correct rpmlint issues - patch submitted upstream to use the correct FSF address - patch submitted upstream to remove unnecessary shebangs @zebob.m@xxxxxxxxx - I wonder if you would be kind enough to double check with an updated review? Thanks again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
