https://bugzilla.redhat.com/show_bug.cgi?id=1970460 --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: 00478eda62bfb80393635e0c5eaa86cf43646e74df1ec61f9fac58f4792e8deabeede3f6dbfbaf8844c850f3ca729f3f27090449670f9eeeafcf2ec3ccd316c0) is original. Ok. FIX: Do not use obsolete %filter_provides_in macro. You can use %__provides_exclude_from <https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/>. But it should not be necessary because these provides are not generated. Summary verified from lib/GooCanvas2/CairoTypes.pm. Ok. FIX: %description must be sentence. And it should provide better explanation than Summary. I recommend DESCRIPTION text found in lib/GooCanvas2/CairoTypes.pm POD. FIX: The License value is wrong. E.g. lib/GooCanvas2/CairoTypes.pm file is "GPL+ or Artistic": This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself, either Perl version 5.22.3 or, at your option, any later version of Perl 5 you may have available. A similar declaration can be found in README and LICENSE files. FIX: There is no point in "%exclude %dir %{perl_vendorarch}/auto/". The directory is not packaged. FIX: Do not do "%exclude %{perl_vendorarch}/perllocal.pod". That's achieved with "Makefile.PL NO_PERLLOCAL=1". FIX: Package the excluded %{_mandir}/man3/GooCanvas2::CairoTypes.3pm.gz file in devel subpackage. FIX: Remove "BuildRequires: perl-macros". You do not call any macro from that package. FIX: Build-require 'perl(strict)' (Makefile.PL:5). FIX: Build-require 'perl(warnigs)' (Makefile.PL:6). 'perl(Gtk3)' is not used at tests. Ok. 'perl(XSLoader)' is not used at tests. Ok. FIX: Build-require 'perl(File::Spec)' (t/00-report-prereqs.t:11). FIX: Do not require "perl(lib)". It's nowhere used. All tests pass. Ok. perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-3.fc35.x86_64.debug perl-GooCanvas2-CairoTypes-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-3.fc35.x86_64.debug perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-debugsource.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-devel.x86_64: W: no-documentation perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/be/6a8c99cf7b9315acc3137a17e6d5881bf66324 ../../../.build-id/be/6a8c99cf7b9315acc3137a17e6d5881bf66324 =========================== 5 packages and 1 specfiles checked; 1 errors, 5 warnings, 1 badness; has taken 1.1 s ========================== rpmlint is Ok. The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=71570148). Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-3.fc35.x86_64.rpm drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib/.build-id/be lrwxrwxrwx 1 root root 80 Jul 9 09:13 /usr/lib/.build-id/be/6a8c99cf7b9315acc3137a17e6d5881bf66324 -> ../../../../usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib64/perl5/vendor_perl/GooCanvas2 -rw-r--r-- 1 root root 1930 Feb 19 01:34 /usr/lib64/perl5/vendor_perl/GooCanvas2/CairoTypes.pm drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2 drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes -rwxr-xr-x 1 root root 15232 Jul 9 09:13 /usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/share/doc/perl-GooCanvas2-CairoTypes -rw-r--r-- 1 root root 85 Feb 19 01:34 /usr/share/doc/perl-GooCanvas2-CairoTypes/Changes -rw-r--r-- 1 root root 1966 Feb 19 01:34 /usr/share/doc/perl-GooCanvas2-CairoTypes/README drwxr-xr-x 2 root root 0 Jul 9 09:13 /usr/share/licenses/perl-GooCanvas2-CairoTypes -rw-r--r-- 1 root root 18331 Feb 19 01:34 /usr/share/licenses/perl-GooCanvas2-CairoTypes/LICENSE $ rpm -q -lv -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-devel-0.001-3.fc35.x86_64.rpm -rw-r--r-- 1 root root 1930 Feb 19 01:34 /usr/lib64/perl5/vendor_perl/GooCanvas2/CairoTypes.pm FIX: There is no point in packaging CairoTypes.pm file twice. Do not produce perl-GooCanvas2-CairoTypes-devel subpackage. FIX: You are missing GooCanvas2::CairoTypes.3pm.gz file. $ rpm -q --requires -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-3.fc35.x86_64.rpm |sort -f | uniq -c 1 glibc >= 2.33.9000-39.fc35 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libcairo-gobject.so.2()(64bit) 1 libgoocanvas-2.0.so.9()(64bit) 1 libperl.so.5.34()(64bit) 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Gtk3) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) $ rpm -q --requires -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-devel-0.001-3.fc35.x86_64.rpm |sort -f | uniq -c 1 GooCanvas2-CairoTypes(x86-64) = 0.001-3.fc35 1 perl(Gtk3) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: "Requires: %{tarname}%{?_isa} = %{version}-%{release}" at devel subpackage is wrong. You want "%{name}{?isa}...". $ rpm -q --provides -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-3.fc35.x86_64.rpm |sort -f | uniq -c 1 GooCanvas2-CairoTypes(x86-64) = 0.001-3.fc35 1 perl(GooCanvas2::CairoTypes) = 0.001 1 perl-GooCanvas2-CairoTypes = 0.001-3.fc35 1 perl-GooCanvas2-CairoTypes(x86-64) = 0.001-3.fc35 FIX: Do not provide "%{tarname}%{?_isa} = %{version}-%{release}". In Fedora we call packages 'perl-Foo' and Perl modules 'perl(Foo)'. This artifical Provide only polutes Fedora repository. $ rpm -q --provides -p ../RPMS/x86_64/perl-GooCanvas2-CairoTypes-devel-0.001-3.fc35.x86_64.rpm |sort -f | uniq -c 1 perl(GooCanvas2::CairoTypes) = 0.001 1 perl-GooCanvas2-CairoTypes-devel = 0.001-3.fc35 1 perl-GooCanvas2-CairoTypes-devel(x86-64) = 0.001-3.fc35 Binary provides are Ok. $ resolvedeps f35-build ../RPMS/x86_64/perl-GooCanvas2-CairoTypes{,-devel}-0.001-3.fc35.x86_64.rpm Binary dependencies are resolvable. Ok. Please correct all 'FIX' items and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
