[Bug 1979316] Review Request: python-lsp-black - A python-lsp-server plugin that adds support to black autoformatter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1979316

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
"wth community maintained" → "with community-maintained"

> mkdir -p %{buildroot}%{_datadir}/licenses/python3-%{short_name}/license
> install -m 644 %{SOURCE1} %{buildroot}%{_datadir}/licenses/python3-%{short_name}

Why not just
---
%prep
cp %{SOURCE1} LICENSE

%files
%license LICENSE
---
?

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ BR/R/P look OK
+ rpmlint finds nothing interesting
+ fedora-review finds nothing interesting

Package is APPROVED.

Suggestion: add Supplements:python-lsp-server.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux