[Bug 1976012] Review Request: wireplumber - A modular session/policy manager for PipeWire

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1976012



--- Comment #19 from Peter Hutterer <peter.hutterer@xxxxxxxxxx> ---
> You should consider converting any build dependencies that are located by Meson via pkgconfig to use pkgconfig() names instead of their package names. That way you'll always get them, even if they change package names.

true, though in this case: wireplumber wants *a lot* of .pc files which are
effectively all provided by glib2-devel and gobject-introspection-devel.
Switching to pkgconfig means either only checking separately for all of those,
making the spec file harder to maintain, or just some of those knowing that
they're in the same package anyway. Both option are IMO worse than requiring
the package name directly. Only systemd and lua-devel could meaningfully be
switched to the pkgconfig check here without any drawbacks.

> These should all be in a libs subpackage, similar to how it was done for pipewire itself. That makes the WirePlumber libraries safe for multi-lib, which may be needed with multi-lib PipeWire too.

Done, same URLs.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux