https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #13 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Otto Urpelainen from comment #12) > I ran fedora-review and otherwise went through everything. Here are still > some findings: > > - Material at servus/md is under different license. Add "and RSA" to License > field and explain the breakdown in a comment. As far as I understand, it is > required to not distribute a license copy (since the license does not demand > it), or to mark md as bundled dependency (since there is no libmd5 or such > available). > There already is: # RSA license for the MD5 code which is based on the RSA licensed code # see ACKNOWLEDGEMENTS.txt for details License: LGPLv3 and RSA License text is in the ACKNOWLEDGEMENTS.txt: %license COPYING COPYING.LESSER ACKNOWLEDGEMENTS.txt I don't think it's a bundling of the library, they just took one their algorithm and based the code on it. Is there anything more to fix? > - Due to no policy of upstreaming all patches, the desktop file should be > submitted upstream and a link to the pr noted in the specfile. > Fixed (I didn't use PR, but github issue). > > Requires: pkgconfig > > Requires: cmake > > What is the reason for these? Are these really needed when doing > BuildRequires: servus-devel in a depending package? > Old school :) It's to install directory structures for the pkgconfig .pc file and the cmake macros, probably not needed today, dropped. > > servus.src:25: W: unversioned-explicit-provides bundled(eyescale-cmake-common) > > > [ ]: Fully versioned dependency in subpackages if applicable. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in servus- > > devel > > Should append '= %{cmake_module_ver}' to Requires line? > Fixed. Spec URL: https://jskarvad.fedorapeople.org/servus/servus.spec RPM URL: https://jskarvad.fedorapeople.org/servus/servus-1.5.2-4.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
