[Bug 1976012] Review Request: wireplumber - A modular session/policy manager for PipeWire

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1976012



--- Comment #16 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Peter Hutterer from comment #15)
> > Take the asterisk off, because the asterisk makes it so RPM doesn't own "%{_datadir}/wireplumber". The slash alone is sufficient for recursive ownership.
> 
> I'm assuming the same applies to
>   %{_includedir}/wireplumber-0.4/*
> and I've fixed them both, thanks.
> 

Yep, thanks! :)

> > Do you actually need this for anything?
> 
> yep, wireplumber uses systemd.pc to determine whether (and where) to install
> the systemd service files.

You should consider converting any build dependencies that are located by Meson
via pkgconfig to use pkgconfig() names instead of their package names. That way
you'll always get them, even if they change package names.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux