Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: man-pages-it https://bugzilla.redhat.com/show_bug.cgi?id=226125 ------- Additional Comments From musuruan@xxxxxxxxx 2007-11-21 03:20 EST ------- [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [!] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: f8-i386 [!] Rpmlint output: Attached to this review because it is too long. [x] Package is not relocatable. [!] Buildroot is correct [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!] License field in the package spec file matches the actual license. License type: Distributable [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 577fec8545d9050da0f4695468a7a29e man-pages-it-2.65.tar.gz 73a11e61f5f42806e20f53f0a5b8446b man-pages-it-extra-0.5.0.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [!] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [-] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [!] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [x] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: f8-i386 [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. === Issues === 1. Summary ends with a period. 2. "Distributable" is not a valid license: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines?highlight=%28guidelines%29%7C%28licensing%29#head-0e7556b4f56a6612e7334b142107e709b3886449 3. BuildRoot is not good: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 4. Source files should use %{name} macro. 5. The following sentence should be removed from the Italian descriptions: "E' possibile scaricare la versione più aggiornata di queste pagine all'indirizzo ftp://ftp.pluto.it/pub/pluto/ildp/man";. The user should not manually download and install the Italian man pages on his own. 6. The description file should not be packaged. This info is already used in the metadata of the RPM. 7. smp_mflag is not used in make. If the parallel building is not supported, it should be inserted a remark before the make invocation. 8. Man pages are encoded in ISO-8859-1. They must be converted to UTF-8. 9. Doc files have spurious executable permissions. 10. In man-pages-it-extra package a line in the description field is too long. 11. man-pages-it should Requires man, because /usr/share/man/it belongs to that package. 12. Buildarchitecture tag is obsolete. Use Buildarch. 13. Maybe it is a good idea to define a extra_name macro too. 14. It should be wise to define macros at the beginning of the spec file. NEEDSWORK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review