Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package review: konserve https://bugzilla.redhat.com/show_bug.cgi?id=361701 ------- Additional Comments From andy.southgate@xxxxxxxxxxxx 2007-11-20 20:17 EST ------- This is a pre-review as part of my own quest for sponsorship, so feel free to ignore it. Points are: o I've dug your .spec file out of the SRPM, but it's handy to have it available for separate download. o Your source RPM doesn't rebuild using mock ( mock konserve-0.10.3-1.fc8.src.rpm ). It attempts to re-run autoconf, which isn't listed as a BuildRequires. Might be a timestamp problem or a side effect of the perl processing of configure. o rpmlint konserve-0.10.3-1.fc8.src.rpm konserve.src: W: mixed-use-of-spaces-and-tabs (spaces: line 54, tab: line 1) o rpmlint konserve-0.10.3-1.fc7.i386.rpm konserve.i386: W: dangling-relative-symlink /usr/share/doc/HTML/en/konserve/common ../common Looks like a problem in the HTML_DIR processing creating a symlink to symlink o Your source lists specifies the Kent mirror. What about http://downloads.sourceforge.net/konserve/konserve-0.10.3.tar.gz instead? o Might as well use the %post and %postun from http://fedoraproject.org/wiki/Packaging/ScriptletSnippets. No need to call gtk-update-icon-cache for locolor. o Supply a vendor for the .desktop file, e.g. fedora. o There's lots of weirdness in the installed .desktop file. o Description: accidently instead of incidently? o Consider keeping timestamps, e.g. make DESTDIR=%{buildroot} INSTALL="install -p" CPPROG="cp -p" install Apart from that, this package does build, install and run. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review