https://bugzilla.redhat.com/show_bug.cgi?id=1978515 --- Comment #13 from Hangbin Liu <haliu@xxxxxxxxxx> --- (In reply to Mikel Olasagasti Uranga from comment #9) > Hi Hangbin, > > One last thing and this should be complete. > > - Use make_install macro > > -mkdir -p $RPM_BUILD_ROOT%{_bindir} > -mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1 > -install -m0755 src/dropwatch $RPM_BUILD_ROOT%{_bindir} > -install -m0644 doc/dropwatch.1 $RPM_BUILD_ROOT%{_mandir}/man1 > - > +%{make_install} > > And then in %files you can change from * to binaries > > -%{_bindir}/* > +%{_bindir}/dropwatch > +%{_bindir}/dwdump > > Same with man pages, but you'll need to patch doc/Makefile.am to include > dwdump's man page with > > > https://github.com/nhorman/dropwatch/commit/ > a6a152f111766afefcdf3a3ba271cdeb3f387553 > > You can use directly: > > Patch1: https://github.com/nhorman/dropwatch/pull/33.patch Hi Mikel, With the new spec file like %install %{make_install} %files %{_bindir}/dropwatch %{_bindir}/dwdump %{_mandir}/man1/dropwatch.1 %{_mandir}/man1/dwdump.1 %doc README.md %license COPYING I got failures [1] """ Making install in doc make[1]: Entering directory '/builddir/build/BUILD/dropwatch-1.5.3/doc' make[2]: Entering directory '/builddir/build/BUILD/dropwatch-1.5.3/doc' make[2]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/builddir/build/BUILDROOT/dropwatch-1.5.3-5.fc34.x86_64/usr/share/man/man1' /usr/bin/install -p -m 644 dropwatch.1 dwdump.1 '/builddir/build/BUILDROOT/dropwatch-1.5.3-5.fc34.x86_64/usr/share/man/man1' make[2]: Leaving directory '/builddir/build/BUILD/dropwatch-1.5.3/doc' make[1]: Leaving directory '/builddir/build/BUILD/dropwatch-1.5.3/doc' [...] Processing files: dropwatch-1.5.3-5.fc34.x86_64 error: File not found: /builddir/build/BUILDROOT/dropwatch-1.5.3-5.fc34.x86_64/usr/share/man/man1/dropwatch.1 error: File not found: /builddir/build/BUILDROOT/dropwatch-1.5.3-5.fc34.x86_64/usr/share/man/man1/dwdump.1 """ Do you know what I missed? [1] https://kojipkgs.fedoraproject.org//work/tasks/3309/71323309/build.log Thanks Hangbin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
