Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libzip - C library for reading, creating, and modifying zip archives https://bugzilla.redhat.com/show_bug.cgi?id=393041 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2007-11-20 16:31 EST ------- > --includedir=%{_includedir}/libzip let's not go inventing problems that don't exist (yet). When/if it ever becomes an issue, we can address it then. Otherwise, I concur with Patrice's comments wrt manpages. MUST item 2. I tried patching in %setup # Avoid lib64 rpaths %if "%{_libdir}" != "/usr/lib" sed -i -e 's|"/lib /usr/lib|"/%{_lib} %{_libdir}|' configure %endif (a common rpath-munching trick), and it seems to work, see http://koji.fedoraproject.org/koji/taskinfo?taskID=251282 call this MUST item 3. So, otherwise, the rest is simple and looks good, address items 1,2,3, and I'll APPROVE this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review