https://bugzilla.redhat.com/show_bug.cgi?id=1978795 Aleksei Bavshin <alebastr89@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |alebastr89@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |alebastr89@xxxxxxxxx Flags|fedora-review? | --- Comment #2 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- > Source0: https://github.com/tree-sitter/%{name}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz You can simplify that to https://github.com/tree-sitter/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz > BuildRequires: cargo > 1.40 Not needed/used in the build. If you intended to build rust bindings, please create a new package from https://crates.io/crates/tree-sitter according to the rust guidelines. However, that's not requires for neovim. Following two lines are required though: BuildRequires: gcc BuildRequires: make > Summary: Asychronous I/O support library That doesn't seem right. Also, you don't have to create lib%{name} subpackages. That's not regulated by the guidelines, but lib%{name} pattern is mostly used when the library is an additional output of the source and the main package is a binary. > export CFLAGS='%{optflags}' %set_build_flags This macro will export all required flags and save you from, for example, forgetting to set LDFLAGS required by Fedora. > %post -n lib%{name} -p /sbin/ldconfig > %postun -n lib%{name} -p /sbin/ldconfig That's no longer necessary since... a while ago. If you want your spec to be compatible with el7, you can use `%{?ldconfig_scriptlets}` instead. Otherwise, please, remove this. > %{_libdir}/libtree-sitter.so.* Please, use part of soname in glob, i.e. `%{_libdir}/libtree-sitter.so.0*`. Rationale: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files ` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
