https://bugzilla.redhat.com/show_bug.cgi?id=1978515 --- Comment #3 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Hi Hangbin, The spec needs some updates and tweaks. I propose the following changes: - Source0 returns 404 -Source0: https://github.com/nhorman/dropwatch/archive/dropwatch-%{version}.tar.gz +Source0: https://github.com/nhorman/dropwatch/archive/v%{version}/%{name}-%{version}.tar.gz - Split and order BuildRequires and Requires - Add missing BuildRequires for gcc - You can simplify using autosetup rather than setup %prep -%setup -%patch0 -p1 +%autosetup -p1 - Use make_build rather than make -make %{?_smp_mflags} +%make_build - No need to remove buildroot -rm -rf $RPM_BUILD_ROOT - Change $RPM_BUILD_ROOT variable to %{buildroot} macro to avoid mixing styles - Use %license macro for license file -%doc COPYING +%license COPYING - For next review link the raw spec file so fedora-review can directly fetch it -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
