Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-Find-Rule-Perl - Common rules for searching for Perl things https://bugzilla.redhat.com/show_bug.cgi?id=392261 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-20 15:16 EST ------- * source files match upstream: c16ea6a65159ff8997705fd4e3fa9cf41ef390263571a40496bd8aab0c23b8c9 File-Find-Rule-Perl-0.03.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(File::Find::Rule::Perl) = 0.03 perl-File-Find-Rule-Perl = 0.03-1.fc9 = perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(UNIVERSAL) perl(base) perl(constant) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=3, Tests=9, 0 wallclock secs ( 0.25 cusr + 0.07 csys = 0.32 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review