https://bugzilla.redhat.com/show_bug.cgi?id=1977733 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mhroncok@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |mhroncok@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity (yes, I realize most of this was introduced by me initially in 2019): 1) %global pypi_name importlib_metadata %global pkg_name importlib-metadata I think this rather complicates the spec as it is harder to read. Consider not using the macros and spell out the names literally as needed in the spec instead. In any case, the package on PyPI is spelled as https://pypi.org/project/importlib-metadata, so the %pypi_name value is a tad confusing. Consider %dist_name if you don't want to get rid of the macros completely. 2) URL: http://importlib-metadata.readthedocs.io/ Please, prefer https urls when available. 3) %description .... Consider marginalizing the description to avoid repetition. Please use a fresh description from upstream, the one in spec seems a bit outdated. 4) # Test dependencies ... Consider expanding the comment to say why we don't fetch those via %pyproject_buildrequirs (I guess theya re mixed with performence, style and coverage deps in upstream, right?). Will run automated checks now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
