[Bug 1976745] ReviewRequest: python-etcd3 - Python client for the etcd API v3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1976745



--- Comment #2 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> ---
> %{?!python3_pkgversion:%global python3_pkgversion 3}

Remove this line.

> Name:           python-etcd3

Should be replaced with python-%{srcname}.

> BuildRequires:  python%{python3_pkgversion}-devel

BuildRequires: python3-devel

> BuildRequires:  python%{python3_pkgversion}-setuptools

BuildRequires: %{py3_dist setuptools}

> %{?python_enable_dependency_generator}

Remove this line.

> %package -n python%{python3_pkgversion}-%{srcname}

%package -n python3-%{srcname}

> %if %{undefined python_enable_dependency_generator} && %{undefined python_disable_dependency_generator}
> # Put manual requires here:
> Requires:       python%{python3_pkgversion}-foo
> %endif

Remove these lines.

> %{summary}, supported under python 2.7, 3.4 and 3.5.

Add %global _description variable and use it here.

> %{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info/

Can be simplified:

%{python3_sitelib}/%{srcname}-*.egg-info/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux