https://bugzilla.redhat.com/show_bug.cgi?id=1976380 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package generated with rust2rpm, simplifying the review: - package builds and installs without errors on rawhide - latest version is packaged - patches are justified and linked to upstream PRs - license is correct, acceptable, and included as %license - test suite is run and all tests pass (unless otherwise justified) PACKAGE APPROVED. Minor issue: Please exclude the "ci" directory from installed files, like this: https://src.fedoraproject.org/rpms/rust-criterion/blob/rawhide/f/rust-criterion.spec#_47 Or even better, suggest upstream that they could use an "exclude = ["ci"]" directive in their Cargo.toml file, since those files are useless in published crates and for downstream users. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
