https://bugzilla.redhat.com/show_bug.cgi?id=976793 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #24 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Otto Urpelainen from comment #23) > I started reviewing this. Running fedora-review is waiting for Servus > dependency to appear in Rawhide, so full review can only happen after that. > But some initial comments: > > > LICENSE.txt > > License issues here, just like there were in Servus. > This file contains this sentence "See file LGPL.txt for the full license". > But that file does not exist. > Also, LGPL is a layer on top of GPL, so full text of that is required also. > Need to contact upstream here, > and possibly add patch the missing licenses if upstream is not active. > https://github.com/Eyescale/Lunchbox/issues/331 Updated the spec. > > # https://github.com/Eyescale/Lunchbox/issues/330 > > #%%check > > #cd %{_vpath_builddir} > > #make test > > If only some test cases fail, patch to disable them and execute the rest. > Much better than blindly disabling everything. > Re-enabled test-suite. > > %cmake -DCOMMON_DOC_DIR=%{_docdir}/%{name} > > When I try to build (after installing servus and servus-devel dependencies), > I get the following error: > > > CMake Error at CMake/common/SubProject.cmake:86 (message): > > Subproject Servus not found in > > /builddir/build/BUILD/Lunchbox-1.17.0/Servus, do: > > > > cmake -DCLONE_SUBPROJECTS=ON > > > > to git-clone it automatically. > > Call Stack (most recent call first): > > CMake/common/SubProject.cmake:148 (add_subproject) > > .gitsubprojects:2 (git_subproject) > > CMake/common/SubProject.cmake:161 (include) > > CMake/common/Common.cmake:161 (include) > > CMakeLists.txt:28 (include) I cannot reproduce. I am building for rawhide, but it shouldn't matter. It seems the cmake macro cannot find servus-devel files, but I don't know why it doesn't work on your system. It seems there is the same problem with the strange library versioning: https://github.com/Eyescale/Lunchbox/issues/332 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
