[Bug 1956580] Review Request: alchemyquest - Reflection game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1956580



--- Comment #6 from Xavier Bachelot <xavier@xxxxxxxxxxxx> ---
- Obsoletes/Provides need to be versioned
https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages

- Add a comment over the openalchemist symlink creation for clarity

- Split long desktop-file-install lines

- The appdata files need to be validated
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage

- Spurious wildcard in the appdata line for alchemyquest in %files

- Nitpick, add a second blank line between the %install and %files sections


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux