[Bug 1974749] Review Request: moolticute - Companion app for Mooltipass password manager devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1974749

Arthur Bols <arthur@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated



--- Comment #0 has been edited ---

Spec URL: https://bols.dev/moolticute.spec
SRPM URL: https://bols.dev/moolticute-0.46.3-1.fc34.src.rpm

Description: 
Moolticute is an easy to use companion app to your Mooltipass device and
extends
the power of the device to more platform/tools. It allows you to manage your
Mooltipass with a cross-platform app and daemon service that handles all USB
communication with the device.

Fedora Account System Username: principis

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=70614369


Hi! As this is my first package, I'm looking for a sponsor. I've been trying to
learn more about
Fedora packaging by doing some preliminary reviews ([0] [1] [2]). By getting
sponsored, I also
hope to save QtPass [3] from being retired.

There are some specific things about this package I'm unsure of:
- The license situation is quite confusing.
  There are many libraries with different licenses:

    BSD 2-clause, BSD 3-clause, GPLv3, GPLv3+, LGPLv3+, MIT, WTF,...

  If I understand the guidelines correctly, the package can be licensed under
the GPLv3 
  because they are compiled into a single binary, and the GPLv3 is the most
restrictive license.

- Builds fail occasionally. I've disable LTO which seems to solve the problem.
  A few failed builds for reference:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=70613103
  https://koji.fedoraproject.org/koji/taskinfo?taskID=70576948

- I'm upstreaming the metainfo.xml file:
  https://github.com/mooltipass/moolticute/pull/868

  Edit: The PR is accepted and it will be included in the next stable release.


[0]: https://bugzilla.redhat.com/show_bug.cgi?id=1973980
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1973680
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1973733
[3]: https://src.fedoraproject.org/rpms/qtpass

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux