Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: getmail - POP3, IMAP4 and SDPS mail retriever with Maildir delivery https://bugzilla.redhat.com/show_bug.cgi?id=365931 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-11-20 10:24 EST ------- Just a quick more comments: Very quick comments: * You can check your srpm/binary rpm by rpmlint - %setup is not quiet (as Patrice said) - For non-executable-script rpmlint complaints like --------------------------------------------------------- getmail.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/getmailcore/logging.py 0644 getmail.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/getmailcore/destinations.py 0644 getmail.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/getmailcore/constants.py 0644 ....... --------------------------------------------------------- this means that scripts which don't have executable permissons should not have shabangs. * Files under %_mandir are automatically marked as %doc. ? By the way, would you consider to shorten the length of one line? For me %doc entry is too long to write in one line. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review