[Bug 1974358] Review Request: fdr - Flight Data Recorder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1974358

Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(mikel@olasagasti. |
                   |info)                       |



--- Comment #5 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
Two small changes and should be complete.

- Change the man8 installed file name, otherwise man can't find it

  $ rpmlint fdr/results/fdr-1.3-1.fc35.x86_64.rpm | grep manual
  fdr.x86_64: W: no-manual-page-for-binary fdrd

  https://github.com/oracle/fdr/blob/master/buildrpm/1.3/fdr.spec#L39

  - install -m 644 fdrd.man %{buildroot}/%{_mandir}/man8
  + install -m 644 fdrd.man %{buildroot}/%{_mandir}/man8/fdrd.8

- Change Summary to be more descriptive:

  "The summary should be a short and concise description of the package."
 
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description


For the future, include link to the raw version of the spec file in GitHub as
otherwise fedora-review doesn't get directly from the BZ.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux