https://bugzilla.redhat.com/show_bug.cgi?id=1975704 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Remi Collet from comment #4) > No, default in Fedora is MIT I read https://communityblog.fedoraproject.org/fedoras-default-license-for-content-is-now-cc-by-sa-4-0/ and I assumed that this also applies to spec files. https://fedoraproject.org/wiki/Licensing:Main#License_of_Fedora_SPEC_Files says > All original Fedora contributions are governed by the Fedora Project Contributor Agreement (FPCA). > This means that unless a spec file contains an explicit license attribution within it, it is available > under the terms of the MIT license. Apart from the outdated reference to MIT, this supports the conclusion that spec files are under CC-BY-SA-4.0 currently. > And I think "implicit" licensing is a terrible error > Too much bad experience with people pulling my work > without any attribution. OK. I think the license header is superfluous, but it's certainly allowed, and if you want to keep it, that fine. Issues: > %dir %{_includedir} fedora-review says: Note: Dirs in package are owned also by: /usr/include(filesystem) So this line should be dropped. > /usr/share/aclocal(filesystem), > /usr/share/man/man3(filesystem) Likewise. + package name is OK + license is acceptable for Fedora (BSD) + license is specified correctly + build and installs fine in mock + obsoletion of the older package is done correctly + BR/Provides/Requires look OK + %check is present and passes rpmlint: libmemcached-awesome.src:43: W: unversioned-explicit-provides bundled(bobjenkins-hash) OK. libmemcached-awesome.x86_64: W: spelling-error Summary(en_US) memcached -> schemed libmemcached-awesome.x86_64: W: spelling-error %description -l en_US memcached -> schemed libmemcached-awesome.x86_64: W: no-documentation Bogus. libmemcached-awesome-devel.x86_64: E: description-line-too-long C for libmemcached-awesome. If you like to develop programs using libmemcached-awesome, Consider wrapping the text. libmemcached-awesome-devel.x86_64: E: standard-dir-owned-by-package /usr/include libmemcached-awesome-devel.x86_64: E: standard-dir-owned-by-package /usr/share/man/man3 See above. libmemcached-awesome-tools.x86_64: W: summary-not-capitalized C libmemcached-awesome tools OK. libmemcached-awesome-tools.x86_64: W: spelling-error %description -l en_US benchmarking -> bench marking, bench-marking, benchmark OK. libmemcached-awesome-tools.x86_64: W: spelling-error %description -l en_US capibilities -> capabilities, possibilities, liabilities Please fix. libmemcached-awesome-tools.x86_64: W: spelling-error %description -l en_US existance -> existence, assistance, resistance Please fix. libmemcached-awesome-tools.x86_64: W: spelling-error %description -l en_US memcached -> schemed OK. 7 packages and 0 specfiles checked; 3 errors, 9 warnings. Package is approved. Please fix the minor issues listed above when importing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
