[Bug 1972301] Review Request: golang-sr-spc-log - simple level log package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1972301



--- Comment #1 from Carl George 🤠 <carl@xxxxxxxxxx> ---
If you like you can remove the forgeurl definition, that's set automatically
based on goipath.  I initially thought several of the others macro definitions
weren't necessary, but after tinkering with it I see that they are necessary
because the forge macros don't seem to like sourcehut.

    -%global forgeurl        https://git.sr.ht/~spc/go-log


I recommend setting the tag based on the version, to avoid having to change the
version in two places.

    -%global tag             0.1.0
    +%global tag             %{version}


Strangely the license and readme aren't being included in the package.  That
should be automatic with the gopkgfiles macro, but it appears there are
multiple bugs with the go forge macros and sourcehut.  I discovered that you
can work around it by setting the topdir macro.

    +%global topdir          %{repo}-%{tag}


You should fill out a summary.  Here's my suggestion, feel free to adjust as
you see fit.

    -Summary:        None
    +Summary:        Level logging for Go


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux