https://bugzilla.redhat.com/show_bug.cgi?id=1975046 Arthur Bols <arthur@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur@xxxxxxxx --- Comment #2 from Arthur Bols <arthur@xxxxxxxx> --- Hi, Please note that this a preliminary review. I checked the license situation (and reread the licensing guidelines) and I think it should be fine. rpmlint reports errors for check_blas.py and check_multi_gpu.py even though you tried to fix it :/ python3-aesara.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/aesara/misc/check_blas.py 644 /usr/bin/env python python3-aesara.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/aesara/misc/check_multi_gpu.py 644 /usr/bin/env python Would it be better to use the sources from github? This way you could include the tests and create a *-doc package. Some small suggestions: - Change pytest to the %pytest macro. - Change python3-setuptools to python3dist(setuptools) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
