https://bugzilla.redhat.com/show_bug.cgi?id=1974114 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra |needinfo?(trpost@rocketmail |in.net) |.com) --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - The Source0 URL seems to be broken. Try: Source0: %{url}/archive/%{version}/%{srcname}-%{version}.tar.gz - The %python_provide macro is obsolete. It has been replaced by %py_provides; but even that is not required here for Fedora (after 32, which is now end-of-life) since the subpackage is conventionally-named. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro. (I know %py_provides is also available on EPEL8; I haven’t checked if it is needed for conventionally-named packages. I don’t think you’re targeting EPEL8 here, since you have two missing dependencies there.) Please remove: %{?python_provide:%python_provide python3-%{srcname}} - Python dependencies that are specified in the package metadata (e.g., in install_requires in setup.py) are automatically generated on all Fedora releases and EPEL8. This can be turned off, but there is no reason to. Therefore, these are redundant and should be removed: Requires: %{py3_dist dj-database-url} Requires: %{py3_dist dj-email-url} Requires: %{py3_dist django-cache-url} Requires: %{py3_dist python-dotenv} Requires: %{py3_dist flask} (They are not really consistent with setup.py anyway; for example, marshmallow is in install_requires but missing from the manual Requires, and dj-database-url/dj-email-url/django-cache-url really belong to the “django” extra; see below.) - You should properly package the metapackage for the “django” extra (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_extras): %{?python_extras_subpkg:%python_extras_subpkg -n python3-requests -i %{python3_sitelib}/*.egg-info django} - This: export PYTHONPATH=%{buildroot}%{python3_sitelib} pytest-%{python3_version} -v would be better written as: %pytest - Consider changing %global _description %{expand: \ Environs is Python library for parsing environment variables. It allows you to store configuration separate from your code, as per [The Twelve-Factor App](https://12factor.net/config) methodology.} to %global _description %{expand: \ Environs is a Python library for parsing environment variables. It allows you to store configuration separate from your code, as per The Twelve-Factor App (https://12factor.net/config) methodology.} since Markdown links will not render in package descriptions, and the square brackets don’t improve readability in plain text. (The above also adds a missing article “a”.) - This package would really benefit from porting to the pyproject-rpm-macros (https://src.fedoraproject.org/rpms/pyproject-rpm-macros). It would let you use generated BuildRequires so you don’t have to keep them updated by hand, and it would slightly simplify handling of the “django” extras metapackage and the files list. I’ll upload an example spec file for this pacakge so you can take a look and decide if you’re interested in switching. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 22 files have unknown license. Detailed output of licensecheck in /home/reviewer/1974114-python- environs/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. Manual requires are incomplete (missing marshmallow); unnecessary (would already be generated from metadata); and include dependencies that belong to the “django” extra. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python (except as noted) [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/sloria/environs/archive/refs/tags/archive/9.3.2/environs-9.3.2.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). (except that some should belong to a “django” extras metapackage) [x]: Package functions as described. (based on tests passing) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments (broken URL) [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-environs-9.3.2-1.fc35.noarch.rpm python-environs-9.3.2-1.fc35.src.rpm python3-environs.noarch: W: spelling-error %description -l en_US https -> HTTP python-environs.src: W: spelling-error %description -l en_US https -> HTTP python-environs.src: W: invalid-url Source0: https://github.com/sloria/environs/archive/refs/tags/archive/9.3.2/environs-9.3.2.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python3-environs (rpmlib, GLIBC filtered): python(abi) python3.10dist(marshmallow) python3.10dist(python-dotenv) python3dist(dj-database-url) python3dist(dj-email-url) python3dist(django-cache-url) python3dist(flask) python3dist(python-dotenv) Provides -------- python3-environs: python-environs python3-environs python3.10-environs python3.10dist(environs) python3dist(environs) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1974114 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Shell-api, Generic Disabled plugins: C/C++, Ocaml, fonts, Perl, Java, PHP, SugarActivity, Haskell, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
