https://bugzilla.redhat.com/show_bug.cgi?id=1973680 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|needinfo?(code@musicinmybra |needinfo?(aniketpradhan1999 |in.net) |@gmail.com) --- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thanks, Rafael. It looks like we found about the same things. (Personally, I think multiple reviews on a package is great!) > - rpmlint is reporting an error: > python3-stopit.noarch: E: summary-too-long C Timeout control decorator and context managers, > raise any exception in another thread This matches my first noted issue. I suggested some alternatives. > - The issue with the license is slightly more than a copy-paste error, as it is related to a license change. > > - Upstream was working on the license change in 2017/2018 and did not finish it, yet. After taking the time to properly review the package and upstream repository, I agree. This is a relic of the old license rather than a copy-paste error. I am, however, convinced by the upstream owner/maintainer’s comment https://github.com/glenfant/stopit/pull/15#issuecomment-364298245 that MIT is indeed the intended license. I think that, considering this, it makes sense to patch the metadata. > - Upstream code has not been tested with Python 3.7+, and as Python 3.10 is bringing more changes. This is true. However, I reviewed the package on Fedora 34, using the usual Rawhide mock chroot, which means the test suite at least passed on Python 3.10. > - Upstream code seems abandoned, is the packager willing to assume/fork the original source code and maintain it in the future? Also noted. This is a pretty simple package, but maintaining an abandonded packager is always an additional burden. (On the other hand, it’s unfortunately common for abandoned dependencies to linger, even in wide use, in the Python ecosystem, and sometimes the reasonable choice is to keep packaging them.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
