[Bug 1973680] Review Request: python-stopit - Raise asynchronous exceptions in other threads and more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1973680



--- Comment #2 from Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> ---
Hey Arthur!

Thanks for the review and your suggestions are really helpful.

* I have fixed the license in setup.py using sed. Hopefully, upstream would
patch the issue soon.
* rpmlint only reports spelling errors. I think it should be fine.
* Added the paragraph to the description. Since the description can span
multiple lines and can be broken into paragraphs, I think the list should be
fine.
* The find command is from a generic spec file that I keep. It basically
removes the unnecessary shebangs from files. Although it might not be required
here, I usually prefer it to remain in the spec so that no such shebangs come
in place in case of an update.

Thanks for the preliminary review. Please do let me know if any other
information is required. Also, in case you are interested in packaging, do
check out our channel #fedora-neuro or https://neuro.fedoraproject.org/ as we
could definitely use your help :D


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux