https://bugzilla.redhat.com/show_bug.cgi?id=1821189 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hiwkby@xxxxxxxxx |aniketpradhan1999@xxxxxxxxx Flags|fedora-review? |fedora-review+ --- Comment #9 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello Aniket, Package APPROVED. Please see the review for details. Best Regards, Hirotaka Wakabayashi ``` Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The packages doesn't install properly because the python3.9dist(connection-pool) and python3.9dist(stopit) don't exist. I installed them locally with --nodeps and reviewed them. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [?]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: snakemake-6.4.1-1.fc34.noarch.rpm snakemake-doc-6.4.1-1.fc34.noarch.rpm snakemake-6.4.1-1.fc34.src.rpm snakemake.noarch: W: spelling-error Summary(en_US) Workflow -> Work flow, Work-flow, Workforce snakemake.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce snakemake.noarch: W: spelling-error %description -l en_US Workflows -> Work flows, Work-flows, Workloads snakemake.noarch: W: spelling-error %description -l en_US workflows -> work flows, work-flows, workloads snakemake.noarch: W: no-manual-page-for-binary snakemake snakemake.noarch: W: no-manual-page-for-binary snakemake-bash-completion snakemake-doc.noarch: W: spelling-error Summary(en_US) Workflow -> Work flow, Work-flow, Workforce snakemake-doc.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce snakemake-doc.noarch: W: spelling-error %description -l en_US Workflows -> Work flows, Work-flows, Workloads snakemake-doc.noarch: W: spelling-error %description -l en_US workflows -> work flows, work-flows, workloads snakemake-doc.noarch: W: hidden-file-or-dir /usr/share/doc/snakemake-doc/html/.buildinfo snakemake-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/snakemake-doc/html/_static/theme.css snakemake.src: W: spelling-error Summary(en_US) Workflow -> Work flow, Work-flow, Workforce snakemake.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce snakemake.src: W: spelling-error %description -l en_US Workflows -> Work flows, Work-flows, Workloads snakemake.src: W: spelling-error %description -l en_US workflows -> work flows, work-flows, workloads snakemake.src:109: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 109) 3 packages and 0 specfiles checked; 0 errors, 17 warnings. Source checksums ---------------- https://github.com/snakemake/snakemake/archive/v6.4.1/snakemake-6.4.1.tar.gz : CHECKSUM(SHA256) this package : 72faf85cf99dc3a4975dbc9c61ab2e9f3e3490a6048897d92ab3c41e9fab7c89 CHECKSUM(SHA256) upstream package : 72faf85cf99dc3a4975dbc9c61ab2e9f3e3490a6048897d92ab3c41e9fab7c89 Requires -------- snakemake (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.9dist(appdirs) python3.9dist(configargparse) python3.9dist(connection-pool) python3.9dist(datrie) python3.9dist(docutils) python3.9dist(filelock) python3.9dist(gitpython) python3.9dist(jsonschema) python3.9dist(nbformat) python3.9dist(psutil) python3.9dist(pulp) python3.9dist(pyyaml) python3.9dist(ratelimiter) python3.9dist(requests) python3.9dist(setuptools) python3.9dist(smart-open) python3.9dist(stopit) python3.9dist(toposort) python3.9dist(wrapt) python3dist(smart-open) snakemake-doc (rpmlib, GLIBC filtered): Provides -------- snakemake: python3.9dist(snakemake) python3dist(snakemake) snakemake snakemake-doc: snakemake-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -n snakemake -m /etc/mock/fedora-34-x86_64.cfg Buildroot used: fedora-34-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: PHP, Haskell, Perl, C/C++, R, Ocaml, SugarActivity, Java, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
