[Bug 1973322] Review Request: python-jsonnet - A data templating language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1973322



--- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
I see three problems at a glance:

- The extension build does not respect the build flags from the environment. In
addition to violating the guidelines
(https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags),
this means debugging symbols are not created and there is no useful -debuginfo
package.

- You have a bundled md5 copylib that needs to be indicated with a virtual
Provides (https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling):

  Provides:       bundled(md5-thilo)

- You have a bundled copy of json (nlohmann_json). Please BR json-devel and
json-static (in accordance with
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries),
remove third_party/json in %prep, and do any necessary minor tweaks to make
sure the build can use the system copy. (For example, you might have to add
-I%{_includedir}/nlohmann to the CFLAGS, or patch the #include directive.)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux