https://bugzilla.redhat.com/show_bug.cgi?id=1955394 zm627 <zheng.ma@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(code@musicinmybra | |in.net) | |needinfo?(ngompa13@xxxxxxxx | |m) --- Comment #17 from zm627 <zheng.ma@xxxxxxxxx> --- Hi Ben, Neal, For the reason it more than a month since the last update, here's a quick retro for the rpm spec and review comments. And I'd like to post the changes here first, waiting for your comments, before it's released to github. Because I have to pass go through the internal release process every time committing to public github. And the process is a little complicated. The spec is to include qatzip app and library into fedora. And after the first round of review, we need to revise the spec with these 4 comments. I'll put my changes here. 1. Revise configure script to provide all of the installation directories explicitly Fix as comment #4 2. Revise configure script to hold fedora compile flags - Add such lines in configure script as the "enable_symbol" one, to hold the CFLAGS and LDFLAGS set by %set_build_flags if [ "$enable_enval" = "yes" ] ; then CFLAGS+=" `echo "$CFLAGS"`" LDFLAGS+=" `echo $LDFLAGS`" fi - Configure with this option in spec file - Qatzip just use these 2 flags set by %set_build_flags, other flags such as FFLAGS are not honored here. 3. Split library package from main package into sub-package - Split as comment #8 - Main package will not depend on the lib package, but the devel package does. Main package only contains binary file and is not linked to libqatzip.so. The libqatzip.so is provided to other applications, so the devel package depends on the libs package. 4. About the %check section The upstream test source code are not invoked by the qatzip itself and is not called during the setup process. It maybe used by some benchmark tools. So I think we can add a brief comment in the spec file(in the spec file?) to explain it, such as # Check section is not available for these functional and performance tests require special hardware. Would you mind to give some comments for the fix, Ben, Neal? Thanks! Zheng -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
